Skip to content

[pull] canary from vercel:canary#1005

Merged
pull[bot] merged 3 commits intocode:canaryfrom
vercel:canary
Apr 28, 2026
Merged

[pull] canary from vercel:canary#1005
pull[bot] merged 3 commits intocode:canaryfrom
vercel:canary

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Apr 28, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

eps1lon and others added 3 commits April 28, 2026 11:00
We don't actually need the full analysis to compute exports. This can
break some task cycles, and might theoretically improve task latency.

The CPU time appears to be marginally higher (but not statistically
significant), but no impact on overall build time:
```
* c4fdcc2 - (14 hours ago) compute exports before final_read_hint() - Niklas Mischkulnig (origin/mischnic/get-exports-without-analyze, mischnic/get-exports-without-analyze)

pnpm next build --experimental-build-mode=compile  378.10s user 58.28s system 760% cpu 57.411 total
pnpm next build --experimental-build-mode=compile  383.64s user 60.32s system 738% cpu 1:00.10 total
pnpm next build --experimental-build-mode=compile  378.70s user 55.65s system 718% cpu 1:00.41 total

* 8ddc1cd - (38 minutes ago) Use OIDC for CodSpeed (#93059) - Niklas Mischkulnig (origin/canary, origin/HEAD, canary)

pnpm next build --experimental-build-mode=compile  376.95s user 58.30s system 755% cpu 57.597 total
pnpm next build --experimental-build-mode=compile  375.85s user 61.75s system 738% cpu 59.230 total
pnpm next build --experimental-build-mode=compile  377.75s user 63.00s system 729% cpu 1:00.39 total
```
Currently doesn't have a measureable performance impact.

Attempt the cheap downcast first and only do the ident reading and
comparison in the uncommon case
@pull pull Bot locked and limited conversation to collaborators Apr 28, 2026
@pull pull Bot added the ⤵️ pull label Apr 28, 2026
@pull pull Bot merged commit 7df1a40 into code:canary Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants